-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull some wording from the presentation and strawman #8
Conversation
rfcs/QueryLevelNullability.md
Outdated
We have chosen `!` because `!` is already being used in the GraphQL spec to indicate that a field in the schema | ||
is non-nullable. Incidentally the same precedent exists in Swift (`!`) and Kotlin (`!!`) which both use similar | ||
syntax to indicate "throw an exception if this value is `null`", so the syntax may even feel familiar to | ||
non-GraphQL developers. | ||
|
||
## Use cases | ||
|
||
#### When a field is necessary to the function of the client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should review these use-cases in a separate PR -- as they've evolved over time, some of them now have overlap and should be combined, and others aren't clear/targeted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to review them one by one
Co-authored-by: Liz Jakubowski <[email protected]>
Co-authored-by: Liz Jakubowski <[email protected]>
The RFCs moved to the working group repo. Closing in favor of a different PR |
This is the first part of a rewrite before we open up the official RFC PR