Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull some wording from the presentation and strawman #8

Closed
wants to merge 7 commits into from

Conversation

twof
Copy link
Owner

@twof twof commented May 18, 2021

This is the first part of a rewrite before we open up the official RFC PR

@twof twof requested review from aprilrd and lizjakubowski May 18, 2021 19:40
We have chosen `!` because `!` is already being used in the GraphQL spec to indicate that a field in the schema
is non-nullable. Incidentally the same precedent exists in Swift (`!`) and Kotlin (`!!`) which both use similar
syntax to indicate "throw an exception if this value is `null`", so the syntax may even feel familiar to
non-GraphQL developers.

## Use cases

#### When a field is necessary to the function of the client
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should review these use-cases in a separate PR -- as they've evolved over time, some of them now have overlap and should be combined, and others aren't clear/targeted

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twof
Copy link
Owner Author

twof commented Nov 4, 2021

The RFCs moved to the working group repo. Closing in favor of a different PR

@twof twof closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants