Add PreReq option sr API #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaitodor
force-pushed
the
add-prereq-option-sr-api
branch
from
ea4728c to
3108f47
Compare
twmb
reviewed
Jan 8, 2025
pkg/sr/clientopt.go
Outdated
| type PreReqFunc func(req *http.Request) error | ||
|
|
||
| // PreReq sets a hook func to call before every request is sent. | ||
| func PreReq(preReq PreReqFunc) ClientOpt { |
There was a problem hiding this comment.
I'd remove the defined type for the function and just have this be an inline function, wdyt?
There was a problem hiding this comment.
Good call! I'm not sure now why I left that in there, but it's not really useful so I removed it. Thanks!
Signed-off-by: Mihai Todor <[email protected]>
Signed-off-by: Mihai Todor <[email protected]>
mihaitodor
force-pushed
the
add-prereq-option-sr-api
branch
from
3108f47 to
1b122a5
Compare
twmb
approved these changes
Jan 20, 2025
mihaitodor
added a commit
to redpanda-data/connect
that referenced
this pull request
Jan 22, 2025
This is a follow-up to twmb/franz-go#867. Since `sr.URLs()` from franz-go doesn't validate URLs during client initialisation, I decided to leave our `url.Parse()` in there because this way we can catch malformed URLs on startup, before any HTTP requests are attempted. Signed-off-by: Mihai Todor <[email protected]>
mihaitodor
added a commit
to redpanda-data/connect
that referenced
this pull request
Jan 22, 2025
This is a follow-up to twmb/franz-go#867. Since `sr.URLs()` from franz-go doesn't validate URLs during client initialisation, I decided to leave our `url.Parse()` in there because this way we can catch malformed URLs on startup, before any HTTP requests are attempted. Signed-off-by: Mihai Todor <[email protected]>
mihaitodor
added a commit
to redpanda-data/connect
that referenced
this pull request
Jan 22, 2025
This is a follow-up to twmb/franz-go#867. Since `sr.URLs()` from franz-go doesn't validate URLs during client initialisation, I decided to leave our `url.Parse()` in there because this way we can catch malformed URLs on startup, before any HTTP requests are attempted. Also update the changelog. We forgot to do it in #3134 Signed-off-by: Mihai Todor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.