Fix isNetClosedErr #264
Merged
Fix isNetClosedErr #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that d5e80b3 reversed its build constraints. It looks like the intent is to use `error.Is` from Go 1.16 onward, and to use `strings.Contains` in Go 1.15. However, per https://pkg.go.dev/cmd/go#hdr-Build_constraints , the go1.15 tag is set for all Go versions from Go 1.15 *onward*. That means that go115.go will be used in Go 1.16 and onward, and go116.go will only be used in Go 1.15. This commit reverses that, so that go115.go (string.Contains) is used in Go 1.15 and go116.go (error.Is) is used in Go 1.16 onward.
twmb
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that d5e80b3 reversed its build constraints. It looks like the intent is to use
error.Isfrom Go 1.16 onward, and to usestrings.Containsin Go 1.15.However, per https://pkg.go.dev/cmd/go#hdr-Build_constraints , the go1.15 tag is set for all Go versions from Go 1.15 onward. That means that go115.go will be used in Go 1.16 and onward, and go116.go will only be used in Go 1.15.
This commit reverses that, so that go115.go (string.Contains) is used in Go 1.15 and go116.go (error.Is) is used in Go 1.16 onward.