Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct error in debug log for request failure #193

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Use correct error in debug log for request failure #193

merged 1 commit into from
Aug 16, 2022

Conversation

keitwb
Copy link
Contributor

@keitwb keitwb commented Aug 16, 2022

It was using plain err twice and never logging the retryErr.

It was using plain `err` twice and never logging the `retryErr`.
Copy link
Owner

@twmb twmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thank you. Were you looking into a problem to find this, or just browsing the code?

@twmb
Copy link
Owner

twmb commented Aug 16, 2022

This will be out in the next release, either a patch release if I fix only #190 and then release, or a feature release if I address everything else right after it. #190 is tricky.

@twmb twmb merged commit e4bd262 into twmb:master Aug 16, 2022
@keitwb
Copy link
Contributor Author

keitwb commented Aug 17, 2022

Nice find, thank you. Were you looking into a problem to find this, or just browsing the code?

I was trying to debug issues with my kafka cluster setup and so I turned on debug logs for franz and noticed that it was showing retries but the error fields in the logs were both nil so I couldn't figure out why it was retrying until I noticed the duplication of err.

@keitwb keitwb deleted the patch-1 branch August 17, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants