config: add producer option to configure transactions backoff duration #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
reviewed
Feb 11, 2022
pkg/kgo/config.go
Outdated
| @@ -1037,6 +1039,12 @@ func TransactionTimeout(timeout time.Duration) ProducerOpt { | |||
| return producerOpt{func(cfg *cfg) { cfg.txnTimeout = timeout }} | |||
| } | |||
|
|
|||
| // ConcurrentTransactionBackoff sets the backoff interval to use during | |||
| // transactional requests in case we encounter CONCURRENT_TRANSACTIONS error. | |||
There was a problem hiding this comment.
Can this documentation be expanded to,
// ConcurrentTransactionBackoff sets the backoff interval to use during
// transactional requests in case we encounter CONCURRENT_TRANSACTIONS error,
// overriding the default 20ms.
//
// Sometimes, when a client begins a transaction quickly enough after finishing
// a previous one, Kafka will return a CONCURRENT_TRANSACTIONS error. Clients
// are expected to backoff slightly and retry the operation. Lower backoffs may
// increase load on the brokers, while higher backoffs may increase transaction
// latency in clients.
twmb
reviewed
Feb 11, 2022
pkg/kgo/config.go
Outdated
| @@ -1037,6 +1039,12 @@ func TransactionTimeout(timeout time.Duration) ProducerOpt { | |||
| return producerOpt{func(cfg *cfg) { cfg.txnTimeout = timeout }} | |||
| } | |||
|
|
|||
| // ConcurrentTransactionBackoff sets the backoff interval to use during | |||
| // transactional requests in case we encounter CONCURRENT_TRANSACTIONS error. | |||
| func ConcurrentTransactionBackoff(backoff time.Duration) ProducerOpt { | |||
There was a problem hiding this comment.
Can this be moved below into a ConsumerOpt? Or perhaps above to just a plain Opt, since transactions kinda encompass both producing & consuming.
|
Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And lower the default from 100ms to 20ms in line with Java Kafka client