rename DecommissionBroker to UnregisterBroker

As was done in the Kafka source. Also, this is apparently not an admin request -- the request only works in raft mode, and any broker can receive the request and forward it.
twmb · Feb 10, 2021 · da52309 · da52309
1 parent f63919a
commit da52309
Show file tree

Hide file tree

Showing 4 changed files with 60 additions and 62 deletions.
diff --git a/generate/definitions/64_decommission_broker b/generate/definitions/64_decommission_broker
diff --git a/generate/definitions/64_unregister_broker b/generate/definitions/64_unregister_broker
@@ -0,0 +1,13 @@
+// For KIP-500 / KIP-631, UnregisterBrokerRequest is an admin request to
+// remove registration of a broker from the cluster.
+UnregisterBrokerRequest => key 64, max version 0, flexible v0+
+  // The broker ID to unregister.
+  BrokerID: int32
+
+// UnregisterBrokerResponse is a response to a UnregisterBrokerRequest.
+UnregisterBrokerResponse =>
+  ThrottleMillis
+  // Any error code, or 0.
+  ErrorCode: int16
+  // The error message, if any.
+  ErrorMessage: nullable-string
diff --git a/pkg/kmsg/generated.go b/pkg/kmsg/generated.go
diff --git a/pkg/kversion/kversion.go b/pkg/kversion/kversion.go
@@ -700,8 +700,9 @@ var maxTip = nextMax(max270, func(v []int16) []int16 {
 	)
 
 	// KAFKA-12249 3f36f9a7ca153a9d221f6bedeb7d1503aa18eff1 KIP-500 / KIP-631
+	// Renamed from Decommission to Unregister in 06dce721ec0185d49fac37775dbf191d0e80e687
 	v = append(v,
-		0, // 64 decommission broker
+		0, // 64 unregister broker
 	)
 
 	return v