Skip to content

Commit

Permalink
kadm: avoid sorting replicas in metadata responses
Browse files Browse the repository at this point in the history
In Kafka, this order is important because the ordering indicates
preferred whatnot.

Closes #194.
  • Loading branch information
twmb committed Aug 22, 2022
1 parent 11e3277 commit bc026a4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/kadm/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,9 @@ func (cl *Client) metadata(ctx context.Context, noTopics bool, topics []string)

Leader: p.Leader,
LeaderEpoch: p.LeaderEpoch,
Replicas: int32s(p.Replicas),
ISR: int32s(p.ISR),
OfflineReplicas: int32s(p.OfflineReplicas),
Replicas: p.Replicas,
ISR: p.ISR,
OfflineReplicas: p.OfflineReplicas,

Err: kerr.ErrorForCode(p.ErrorCode),
}
Expand Down

0 comments on commit bc026a4

Please sign in to comment.