This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Piping prune function through the VersionedStore factory method #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current approach would be to add a proxy batched store new myClass(store: BatchedStore) extends ProxyBatchedStore...etc.. Though i've no issue with it being a constructor arg here. Will take a look when the build is green in more detail |
|
(restarted as looks like might just be transient test issues) |
| def apply[K, V]( | ||
| rootPath: String, | ||
| versionsToKeep: Int = VersionedKeyValSource.defaultVersionsToKeep, | ||
| pruneFn: ((K,V), Timestamp) => Boolean = PrunedSpace.neverPruned.prune _)( |
There was a problem hiding this comment.
Looking at this in more detail, it looks like this Should be a PrunedSpace, and if we want a PrunedSpace apply method that takes the pruning function?
def apply(fn: (K,V), Timestamp) => Boolean) = new PrunedSpace....
added 2 commits
March 11, 2014 16:55
|
Makes sense, updated accordingly. |
|
LGTM, will merge when green. Thanks! |
ianoc
added a commit
that referenced
this pull request
Mar 12, 2014
Piping prune function through the VersionedStore factory method
|
Merged, thanks! |
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Disable coveralls, shows up as builds pending that are long finished
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively one could also pass a PrunedSpace directly, though I prefer passing a function. Either way it seems useful, as currently the only way to prune is to extend BatchedStore and override.