This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/fix bugs hdfs #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #352 |
| val keepers = versions.takeRight(versionsToKeep).toSet | ||
| versions | ||
| .filter(keepers.contains(_)) | ||
| .foreach(deleteVersion(_)) |
There was a problem hiding this comment.
isn't this going to drop versions to keep?
There was a problem hiding this comment.
Don't you want filterNot(keepers)? (note set extends function so that is legit.
There was a problem hiding this comment.
True, good catch -- Also do we actually need cleanup? I don't see it called.
|
Looks great! Thanks for porting this! |
|
You are right. The HDFSState never writes that a job is running to prevent two from running at the same time. That would be really nice: try to create a file, and if that file is more recent than a threshold (to prevent a crash from deadlocking us), we stop in prepare. Else, we have created a file, and then we go on. We didn't handle that yet: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnynek Looking at how we were using this, there's no locking/state written out. Does it need it/do we have it somewhere else?