This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/move dag to core #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/move_dag_to_core Conflicts: summingbird-storm/src/main/scala/com/twitter/summingbird/storm/PlannedTopology.scala summingbird-storm/src/main/scala/com/twitter/summingbird/storm/StormPlatform.scala summingbird-storm/src/test/scala/com/twitter/summingbird/storm/TopologyPlannerLaws.scala
|
|
||
| def add(node: Producer[P, _]): Node[P] | ||
|
|
||
| def reverse: Node[P] |
There was a problem hiding this comment.
skeptical we need this. Seems like an internal detail.
There was a problem hiding this comment.
I'm not sure of a particularly great way when I only have the type to give me a new version of the subclass?
Use case is that when I walk the producer graph I end up with Node's which are arranged source -> sink, but since we look at our graphs normally DAG'd sink to source it makes sense to reverse them. But at that time we need some function in the subclass to do the reverse?
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Use semigroup in StateWithError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.