This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Fix RestartableHttpClient. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arts, so we have to create a new one. So don't allow passing in a single instance of connectionmanager; it won't work. Instead, create a new one with the given schemeregistry, which can now be provided - this is the main thing to customize in a connectionmanager anyways
|
This seems much better than the ClientConnectionManagerFactory way. Ship it! |
|
Can you add a test case showing that this fixes issue #113 ? |
|
Added a minimal test case to reproduce the behavior and cleaned up imports. |
|
Addressed comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It kills its connectionmanager when it restarts, so we have to create a new one. So don't allow passing in a single instance of connectionmanager; it won't work. Instead, create a new one with the given schemeregistry, which can now be provided - this is the main thing to customize in a connectionmanager anyways.