-
Notifications
You must be signed in to change notification settings - Fork 155
Cross-build (most projects) for Scala 2.12.0 #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b3d4d50
WIP
JoshRosen 99e51a0
Use Kryo 3.1.0-SNAPSHOT; register ClosureSerializer
JoshRosen c98f80e
Update ClosureCleaner to use ASM 5 APIs:
JoshRosen 97573d3
Use sbt-doge to exclude certain subprojects from the 2.12 build.
JoshRosen 26e8bd0
Remove testOptions change.
JoshRosen c11010f
Only register ClosureSerializer when running on Java 8 JDK.
JoshRosen a17fd8e
Update to use sbt-doge's +++ "strict aggregation" operator.
JoshRosen 3376e7b
Workaround to fix PriorityQueueTest (there's probably a better way to…
JoshRosen 3636f1c
Replace Unit.box() call by scala.runtime.BoxedUnit.UNIT
JoshRosen 25e982b
Update to 2.12.0 final.
JoshRosen c99ec53
Merge remote-tracking branch 'origin/develop' into scala-2.12
JoshRosen 753f03c
Undo BoxedUnit workaround since it's no longer necessary.
JoshRosen 074dc8d
Create Java8ClosureRegistrar
JoshRosen b2ec04e
Fix Java8ClosureRegistrar; standardize formatting.
JoshRosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -299,7 +299,7 @@ class KryoSpec extends WordSpec with Matchers with BaseProperties { | |
| toList(rt(qr)) should equal(qrlist) | ||
| } | ||
| "Ranges should be fixed size" in { | ||
| val MAX_RANGE_SIZE = 188 // what seems to be needed. | ||
| val MAX_RANGE_SIZE = 447 // what seems to be needed. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's a bummer.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😦 We could make this constant a function of Scala version if you'd like to keep using the old value for the old build matrix entries. |
||
| serialize((1 to 10000)).size should be < (MAX_RANGE_SIZE) // some fixed size | ||
| serialize((1 to 10000 by 2)).size should be < (MAX_RANGE_SIZE) // some fixed size | ||
| serialize((1 until 10000)).size should be < (MAX_RANGE_SIZE) // some fixed size | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: what's the best place to register this? And what happens if it already happens to have been registered by some other means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make a
Java8ClosureRegistrarthat is anIKryoRegistrar: https://github.com/twitter/chill/blob/develop/chill-java/src/main/java/com/twitter/chill/IKryoRegistrar.java and it should be a no-op when we are not on java8 (as you have below).See for instance the
PackageRegistrar.all()above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea; will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, forgot about this comment until now. I've created a
Java8ClosureRegistrarto abstract away this code.