make SSOne/SSMany constructors private and add apply method with count #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SSMany(capacity, counters, bucketsFromCounters(counters)) | ||
|
|
||
| private[algebird] def apply[T](one: SSOne[T]): SSMany[T] = | ||
| SSMany(one.capacity, Map(one.item -> (1L, 0L)), SortedMap(1L -> Set(one.item))) | ||
| } | ||
|
|
||
| case class SSMany[T](capacity: Int, counters: Map[T, (Long, Long)], buckets: SortedMap[Long, Set[T]]) extends SpaceSaver[T] { | ||
| case class SSMany[T] private (capacity: Int, counters: Map[T, (Long, Long)], buckets: SortedMap[Long, Set[T]]) extends SpaceSaver[T] { |
There was a problem hiding this comment.
should this be private[algebird] why are the others if not?
There was a problem hiding this comment.
the 2 apply methods in companion object are now both called from other classes so they both need to be private[algebird]. the one on line 110 had to be opened up because of new SpaceSaver.apply method on line 16.
the main constructor is not used outside the class. it can also very easily be used incorrectly (e.g. create buckets that are inconsistent with counters), so i rather keep it as private as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constructors should have been private from the beginning. The documentation already says other constructors should be used instead.
Also a new constructor/apply is added to set the exact count of an item instead of default value of 1