Refactor MapAggregator #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use string interpolation instead of .format() - inline prepare, present, semigroup methods - use more clear variable names: - rename i to aggrCount - rename nums to aggrNums - rename semiType to semigroup (it refers to field name, not type), add semigroupType which actually refers to type
|
P.S. we found it quite weird that currently having an aggregator created by val aggr = MapAggregator(
"sum" -> Aggregator.sum,
"min" -> Aggregator.min
)
// can't do this yet
val keys = aggr.keysLooks like this would need to introduce a |
| |def apply[K, A, $bs, C]($inputAggs): ${aggType}Aggregator[A, $tupleBs, Map[K, C]] = { | ||
| | new ${aggType}Aggregator[A, $tupleBs, Map[K, C]] { | ||
| | def prepare(a: A) = ( | ||
| | ${aggrNums.map(i => s"agg$i._2.prepare(a)").mkString(", ")} |
There was a problem hiding this comment.
|
+1 to Ian's suggestion. Also I like the idea of: trait MapAggregator[A, B, K, C] extends Aggregator[A, B, Map[K, C]] {
def keys: Set[K]
}
trait MapMonoidAggregator[A, B, K, C] extends MonoidAggregator[A, B, Map[K, C]] {
def keys: Set[K]
} |
|
much cleaner code-gen! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare,present,semigroup@johnynek