Make the AsyncListSum be immutable again, identical performance to its m... #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s mutable version now in benchmarks.
| commit | ||
| (elementsCommitted, privBuf) | ||
| } | ||
| def dump: (Int, Iterable[Value]) = (size, privBuf) |
There was a problem hiding this comment.
lazy val and privBuf.reverse
…mmutative (i.e. keep the order)
johnynek
added a commit
that referenced
this pull request
Apr 18, 2014
Make the AsyncListSum be immutable again, identical performance to its m...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...utable version now in benchmarks.
fixes #307
Creating Thyme instances and warming busywork methods...done in 5.36 s
Warming up benchmarking...done in 4.51 s
Warming up head-to-head benchmarking...done in 4.36 s
Warming up computational complexity benchmarking...done in 3.75 s
Total number of input keys: 1000
Num input tuples: 10000
Buffer size is: BufferSize(1000)
========= STARTING BenchmarkHLL(0,0,true) ================
(13,Benchmark comparison (in 9.502 s): AsyncListSum Vs AsyncListSumImmutable
AsyncListSum vs AsyncListSumImmutable
Not significantly different (p ~= 0.2015)
Time ratio: 1.00951 95% CI 0.99473 - 1.02429 (n=20)
AsyncListSum 29.84 ms 95% CI 29.53 ms - 30.15 ms
AsyncListSumImmutable 30.13 ms 95% CI 29.82 ms - 30.44 ms
Warning: order-of-evaluation effects in timing (p ~= 0.0207) of up to 7.595%)
(13,Benchmark comparison (in 7.132 s): AsyncListSumImmutable Vs AsyncListSum
AsyncListSumImmutable vs AsyncListSum
Not significantly different (p ~= 0.7817)
Time ratio: 0.99518 95% CI 0.96053 - 1.02982 (n=20)
AsyncListSumImmutable 29.68 ms 95% CI 28.95 ms - 30.41 ms
AsyncListSum 29.53 ms 95% CI 28.81 ms - 30.26 ms)
========= FINISHED BenchmarkHLL(0,0,true) ================
Total number of input keys: 1000
Num input tuples: 10000
Buffer size is: BufferSize(1000)
Sketchmap width: 2000
Sketchmap depth: 5
========= STARTING BenchmarkSketchMap(0,0,true) ================
(13,Benchmark comparison (in 67.48 s): AsyncListSum Vs AsyncListSumImmutable
AsyncListSum vs AsyncListSumImmutable
Not significantly different (p ~= 0.2024)
Time ratio: 1.00148 95% CI 0.99919 - 1.00376 (n=20)
AsyncListSum 274.0 ms 95% CI 273.6 ms - 274.5 ms
AsyncListSumImmutable 274.4 ms 95% CI 274.0 ms - 274.9 ms
Individual benchmarks not fully consistent with head-to-head (p ~= 3.866e-05)
AsyncListSum 282.1 ms 95% CI 277.7 ms - 286.4 ms
AsyncListSumImmutable 274.7 ms 95% CI 274.5 ms - 274.8 ms)
(13,Benchmark comparison (in 66.76 s): AsyncListSumImmutable Vs AsyncListSum
AsyncListSumImmutable vs AsyncListSum
Not significantly different (p ~= 0.6573)
Time ratio: 0.99839 95% CI 0.99115 - 1.00563 (n=20)
AsyncListSumImmutable 276.0 ms 95% CI 274.6 ms - 277.4 ms
AsyncListSum 275.5 ms 95% CI 274.1 ms - 276.9 ms)
========= FINISHED BenchmarkSketchMap(0,0,true) ================