Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #60 and adds a new "item-name" flag to allow for the item name to be set. #64

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

lleadbet
Copy link
Contributor

@lleadbet lleadbet commented Jun 1, 2021

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Adds a new item-name flag to support #60 as well as adding this support to the CoPo topics.

Description of Changes:

  • Adds item-name/n as a flag for item name support (game name/copo title)
  • Updated tests to check
  • FIxed some small issues with the stream-chjange topic

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet requested review from a team, hiGarza and BraxtonLanc43 and removed request for a team June 1, 2021 16:24
@lleadbet lleadbet self-assigned this Jun 1, 2021
Copy link
Contributor

@BraxtonLanc43 BraxtonLanc43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one note but looks good to me.

@lleadbet lleadbet merged commit 150e1e1 into main Jun 1, 2021
@lleadbet lleadbet deleted the feature/fix-issue-60 branch June 1, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants