Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventSub: followed_at #59

Merged
merged 3 commits into from
Apr 19, 2021
Merged

EventSub: followed_at #59

merged 3 commits into from
Apr 19, 2021

Conversation

BarryCarlyon
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

followed_at was added to event sub for follow events but is not reflected in the CLI

Description of Changes:

Add followed_at to the follow EventSub

  • Update the Models/follow
  • Update the events/follow_event

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet self-requested a review April 19, 2021 15:29
lleadbet
lleadbet approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, :shipit:

@lleadbet lleadbet merged commit 80f8da3 into twitchdev:main Apr 19, 2021
@BarryCarlyon
Copy link
Contributor Author

Am I a gopher now?

@BarryCarlyon BarryCarlyon deleted the BarryCarlyon-patch-1 branch January 3, 2022 02:12
@BarryCarlyon BarryCarlyon restored the BarryCarlyon-patch-1 branch January 3, 2022 02:12
@BarryCarlyon BarryCarlyon deleted the BarryCarlyon-patch-1 branch January 3, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lleadbet lleadbet lleadbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BarryCarlyon @lleadbet