Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating build process to add HEAD + M1 support, addressing #52 #55

Merged
merged 4 commits into from
Apr 16, 2021

Conversation

lleadbet
Copy link
Contributor

@lleadbet lleadbet commented Apr 6, 2021

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

#52 Identified that M1 support was broken, so this PR introduces a temporary fix until CGO is no longer needed.

Description of Changes:

  • Adds support for both a HEAD and M1 release, meaning that Brew now supports both bleeding edge clients (using --head in the install flags) as well as M1 via local building

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet requested review from a team, angpt and MonstersOnParade and removed request for a team April 6, 2021 19:07
@lleadbet lleadbet self-assigned this Apr 6, 2021
@lleadbet lleadbet merged commit c67cbc1 into main Apr 16, 2021
@lleadbet lleadbet deleted the feature/m1 branch April 16, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants