Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new RandomInt utility + updating tests #50

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Conversation

lleadbet
Copy link
Contributor

@lleadbet lleadbet commented Mar 19, 2021

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

This simply adds a new RandomInt function to replace usage of RandomViewerCount across a few places, as well as updating tests to cover the new utilities.

Description of Changes:

  • Adds RanomInt as a utility function/wrapper for getting a random integer between 0 and the max provided
  • Updates unit tests to add additional coverage

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet requested review from a team, angpt and MonstersOnParade and removed request for a team March 19, 2021 19:07
@lleadbet lleadbet self-assigned this Mar 19, 2021
@lleadbet lleadbet merged commit 4296faa into main Apr 16, 2021
@lleadbet lleadbet deleted the bugfix/utility-updates branch April 16, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants