Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating api tests to cover autopagination changes fully #49

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

lleadbet
Copy link
Contributor

@lleadbet lleadbet commented Mar 19, 2021

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

The autopagination PR added new functionality but was missing a few tests to cover the added code fully. This PR adds in additional unit tests to cover any missing edge-cases.

Description of Changes:

  • Adds additional tests to the the api package to cover additional cases added by the autopagination feature

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet self-assigned this Mar 19, 2021
@lleadbet lleadbet requested review from a team, vpolouchkine and Jameka and removed request for a team March 19, 2021 19:07
@lleadbet lleadbet merged commit df96efa into main Apr 14, 2021
@lleadbet lleadbet deleted the bugfix/api-test-updates branch April 14, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants