Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream up down events #45

Merged
merged 7 commits into from
Mar 12, 2021
Merged

Stream up down events #45

merged 7 commits into from
Mar 12, 2021

Conversation

hiGarza
Copy link
Contributor

@hiGarza hiGarza commented Mar 11, 2021

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Complete Stream Up/Down support by adding Websub support

Description of Changes:

  • Added a new case on the Transport switch of the streamdown event to support WebSub.
  • Created a new StreamDownWebSubResponse model to support the above case.
  • Added a new case to the Transport switch of the streamup event to support Websub.
  • Created a new StreamUpWebSubResponse model for the above.

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

lleadbet
lleadbet suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was a docs issue for streamup, but streamdown lgtm.

@lleadbet lleadbet self-requested a review March 11, 2021 23:54
lleadbet
lleadbet approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@hiGarza hiGarza merged commit c152c68 into main Mar 12, 2021
@lleadbet lleadbet deleted the stream_up_down_events branch March 12, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lleadbet lleadbet lleadbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiGarza @lleadbet