Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_change support addition #44

Merged
merged 5 commits into from
Mar 10, 2021
Merged

stream_change support addition #44

merged 5 commits into from
Mar 10, 2021

Conversation

BraxtonLanc43
Copy link
Contributor

Adding support for "stream_change" websub and eventsub.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Adding Websub and Eventsub spoofing support for "stream_change" topic.

Description of Changes:

twitch event trigger stream_change -d "Title Update" to simulate the updating of a channel's stream title

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • [not yet but I will] I have updated the documentation (if applicable)

Adding support for "stream_change" websub and eventsub.
@BraxtonLanc43 BraxtonLanc43 requested a review from lleadbet March 9, 2021 22:19
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things to clean up; additionally (and I missed this) but you can lint the project with:

golint ./...

Addressing first comments by editing "stream_change" to "stream-change" as the trigger. Adding "TagIDs".
@BraxtonLanc43
Copy link
Contributor Author

Running the golint command returns over 200 lines of suggestions. Are there specific formatting styles that are missing or improper that I can update? Doesn't look like there is anything specific to StreamChange stuff that aren't there for others as well?

@lleadbet
Copy link
Contributor

Running the golint command returns over 200 lines of suggestions. Are there specific formatting styles that are missing or improper that I can update? Doesn't look like there is anything specific to StreamChange stuff that aren't there for others as well?

You can ignore those as long as nothing is returned from the files you're working on; most are around comments that can safely be ignored until I get around to adding comments to all exported functions.

@lleadbet lleadbet self-requested a review March 10, 2021 18:39
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to merge

@@ -113,6 +115,7 @@ Allows you to test if your webserver responds to subscription requests properly.
| `update-redemption` | Channel Points EventSub event for a redemption being updated. |
| `raid` | Channel Raid event with a random viewer count. |
| `revoke` | User authorization revoke event. Uses local Client as set in `twitch configure` or generates one randomly. |
| `stream_change` | Stream changed event. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missed spot, but not worth blocking the entire merge; I can fix afterwards.

@BraxtonLanc43 BraxtonLanc43 merged commit 89dd919 into main Mar 10, 2021
@BraxtonLanc43 BraxtonLanc43 deleted the stream_change_Add branch March 10, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants