Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 221 #222

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix 221 #222

merged 2 commits into from
Apr 4, 2023

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Apr 4, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Addresses #221

Description of Changes:

  • Changed ListenAndServe to listen first and surface any binding issues before serving the HTTP server
  • Added --ip and --port flags to 'twitch token'
  • Added --ip flag to EventSub WebSocket server under 'twitch event websocket start'

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo merged commit dad323d into main Apr 4, 2023
@Xemdo Xemdo deleted the fix-221 branch April 4, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Xemdo