Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitch Creator Goals - Event Sub - SUPPORT #112

Merged
merged 5 commits into from
Nov 1, 2021
Merged

Twitch Creator Goals - Event Sub - SUPPORT #112

merged 5 commits into from
Nov 1, 2021

Conversation

jackmcguire1
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Feature

Add support for Twitch creator goal event-subs

Description of Changes:

  • Defined new Goals type
  • Defined new Goal events
  • Defined Unit tests for Goal Events

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@jackmcguire1 jackmcguire1 mentioned this pull request Oct 22, 2021
Closed
@jackmcguire1
Copy link
Contributor Author

@lleadbet

@lleadbet lleadbet self-requested a review October 25, 2021 18:52
@lleadbet lleadbet assigned lleadbet and jackmcguire1 and unassigned lleadbet Oct 25, 2021
lleadbet
lleadbet suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes needed; looks good broadly, however.

internal/events/types/goal/goal_event.go Outdated Show resolved Hide resolved
internal/events/types/goal/goal_event.go Show resolved Hide resolved
internal/events/types/goal/goal_event.go Outdated Show resolved Hide resolved
internal/events/types/goal/goal_event_test.go Show resolved Hide resolved
@jackmcguire1
Improvements
1602fbf 
- Fixed Transport type handling
- pass correct goal start date
@jackmcguire1
Copy link
Contributor Author

@lleadbet pushed improvements

lleadbet and others added 2 commits October 27, 2021 08:33
@lleadbet
Merge branch 'main' into goals-event-sub
ba87aaf
@jackmcguire1
Remove websub transport references
383e537 
- Remove websub transport references in events/types/goals_events.go
@jackmcguire1
Copy link
Contributor Author

@lleadbet rebased!

@jackmcguire1
MockEvent interface methods
4d68249 
- GetTopic
- GetEventSubAlias
- ValidTrigger
- ValidTransport
lleadbet
lleadbet approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@lleadbet lleadbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the changes.

@lleadbet lleadbet merged commit 9ad36fe into twitchdev:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lleadbet lleadbet lleadbet approved these changes

Assignees

@jackmcguire1 jackmcguire1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackmcguire1 @lleadbet