addressing feedback

twitchdev · Mar 8, 2021 · 36faa7c · 36faa7c
1 parent fdf9bdd
commit 36faa7c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 52 deletions.
diff --git a/internal/events/types/streamdown/streamdown.go b/internal/events/types/streamdown/streamdown.go
@@ -52,20 +52,14 @@ func (e Event) GenerateEvent(params events.MockEventParameters) (events.MockEven
 			},
 			Event: models.StreamDownEventSubEvent{
 				BroadcasterUserID:    params.ToUserID,
-				BroadcasterUserLogin: params.ToUserID,
+				BroadcasterUserLogin: params.ToUserName,
 				BroadcasterUserName:  params.ToUserName,
 			},
 		}
 		event, err = json.Marshal(body)
 		if err != nil {
 			return events.MockEventResponse{}, err
 		}
-	case models.TransportWebSub:
-		body := models.FollowWebSubResponse{} // replace with actual model in internal/models
-		event, err = json.Marshal(body)
-		if err != nil {
-			return events.MockEventResponse{}, err
-		}
 	default:
 		return events.MockEventResponse{}, nil
 	}

diff --git a/internal/events/types/streamdown/streamdown_test.go b/internal/events/types/streamdown/streamdown_test.go
@@ -34,25 +34,6 @@ func TestEventSub(t *testing.T) {
 	// write actual tests here (making sure you set appropriate values and the like) for eventsub
 }
 
-func TestWebSub(t *testing.T) {
-	a := util.SetupTestEnv(t)
-
-	params := *&events.MockEventParameters{
-		FromUserID: fromUser,
-		ToUserID:   toUser,
-		Transport:  models.TransportWebSub,
-		Trigger:    "unsubscribe",
-	}
-
-	r, err := Event{}.GenerateEvent(params)
-	a.Nil(err)
-
-	var body models.SubWebSubResponse // replace with actual value
-	err = json.Unmarshal(r.JSON, &body)
-	a.Nil(err)
-
-	// write tests here for websub
-}
 func TestFakeTransport(t *testing.T) {
 	a := util.SetupTestEnv(t)
 

diff --git a/internal/events/types/streamup/streamup.go b/internal/events/types/streamup/streamup.go
@@ -53,7 +53,7 @@ func (e Event) GenerateEvent(params events.MockEventParameters) (events.MockEven
 			Event: models.StreamUpEventSubEvent{
 				ID:                   util.RandomUserID(),
 				BroadcasterUserID:    params.ToUserID,
-				BroadcasterUserLogin: params.ToUserID,
+				BroadcasterUserLogin: params.ToUserName,
 				BroadcasterUserName:  params.ToUserName,
 				Type:                 "live",
 				StartedAt:            util.GetTimestamp().Format(time.RFC3339Nano),
@@ -63,12 +63,6 @@ func (e Event) GenerateEvent(params events.MockEventParameters) (events.MockEven
 		if err != nil {
 			return events.MockEventResponse{}, err
 		}
-	case models.TransportWebSub:
-		body := models.FollowWebSubResponse{} // replace with actual model in internal/models
-		event, err = json.Marshal(body)
-		if err != nil {
-			return events.MockEventResponse{}, err
-		}
 	default:
 		return events.MockEventResponse{}, nil
 	}

diff --git a/internal/events/types/streamup/streamup_test.go b/internal/events/types/streamup/streamup_test.go
@@ -34,25 +34,6 @@ func TestEventSub(t *testing.T) {
 	// write actual tests here (making sure you set appropriate values and the like) for eventsub
 }
 
-func TestWebSub(t *testing.T) {
-	a := util.SetupTestEnv(t)
-
-	params := *&events.MockEventParameters{
-		FromUserID: fromUser,
-		ToUserID:   toUser,
-		Transport:  models.TransportWebSub,
-		Trigger:    "unsubscribe",
-	}
-
-	r, err := Event{}.GenerateEvent(params)
-	a.Nil(err)
-
-	var body models.SubWebSubResponse // replace with actual value
-	err = json.Unmarshal(r.JSON, &body)
-	a.Nil(err)
-
-	// write tests here for websub
-}
 func TestFakeTransport(t *testing.T) {
 	a := util.SetupTestEnv(t)