-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9719] Support contextvars in coroutines #1192
Merged
Merged
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2006d09
failing test
hawkowl 3c020d0
fix impl and add more tests
hawkowl 6c16077
changelog
hawkowl e003a0a
fixes
hawkowl 03d4605
fixes
hawkowl 76fad8a
fixes
hawkowl 29f835c
fixes
hawkowl fd8be59
Merge branch 'trunk' into 9719-contextvars
hawkowl f1e7838
fixes
hawkowl 67d1297
test for async await
hawkowl 7693044
Merge remote-tracking branch 'origin/trunk' into 9719-contextvars
hawkowl 03180a4
linting errors
hawkowl 2dec49c
lint
hawkowl 6fb9987
Merge branch 'trunk' into 9719-contextvars
hawkowl 0ab920b
dont use a broken pywin32
hawkowl 9123b41
Merge branch '9719-contextvars' of github.com:twisted/twisted into 97…
hawkowl cc73065
Merge branch 'trunk' into 9719-contextvars
glyph b7a1efe
Merge branch 'trunk' into 9719-contextvars
hawkowl bb2544c
Merge branch 'trunk' into 9719-contextvars
glyph b6952f1
Merge remote-tracking branch 'origin/trunk' into 9719-contextvars
hawkowl b3f6976
fix lint
hawkowl 56469b1
set to just async/await and inlinecallbacks
hawkowl 369d361
fix 3.5/3.6 giving different warnings
hawkowl cd96d14
fix
hawkowl 065e3bf
newsfile update
hawkowl dc56137
address trivial lint failures
glyph 10ee73c
focus on the feature in the changelog entry rather than the implement…
glyph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
twisted.internet.defer.inlineCallbacks and ensureDeferred will now capture the current contextvars context when ran, and restore the context when resuming the coroutine between yields. This functionality requires Python 3.7+, or the contextvars PyPI backport to be installed for Python 3.5-3.6. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar / agreement nitpick: "when ran" ➡️ "when running"
(also: pretty sure contextvars only supports 3.6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the backport I mean