VIDEO-6587 | Remove Plan B in SDK #1656

charliesantos · 2021-11-30T18:34:29Z

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

I acknowledge that all my contributions will be made under the project's license.

manjeshbhargav

LGTM overall. Please add a CHANGELOG.md entry.

test/unit/spec/signaling/v2/peerconnection.js

manjeshbhargav · 2021-11-30T20:56:42Z

test/unit/spec/util/sdp/index.js

@@ -250,253 +141,9 @@ describe('setSimulcast', () => {
      });
    });
  });
-
-  describe('when a subsequent offer disables RTX', () => {


Any reason why this test is removed?

This whole describe section only has one test, and the assertions are all based on a plan-b sdp. See line 481.

Co-authored-by: Manjesh Malavalli <[email protected]>

…-sdk

CHANGELOG.md

Co-authored-by: Manjesh Malavalli <[email protected]>

* VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]>

* VIDEO-7728 | Better Preflight Errors (#1689) * Adding better errors on preflight * lint * Update docs * Changelog * Update docs * Convert error to string * Adding timestamp to progress events * Properly raising signaling errors * lint * Update tests * Mak's feedback * Update test * Feature/remove plan b (#1697) * VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Fix unit test from merge * 2.20.0-rc2 * 2.20.0-dev * Update doc * Update changelog Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]>

* Merge Preflight and PlanB removal feature branch (#1702) * VIDEO-7728 | Better Preflight Errors (#1689) * Adding better errors on preflight * lint * Update docs * Changelog * Update docs * Convert error to string * Adding timestamp to progress events * Properly raising signaling errors * lint * Update tests * Mak's feedback * Update test * Feature/remove plan b (#1697) * VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Fix unit test from merge * 2.20.0-rc2 * 2.20.0-dev * Update doc * Update changelog Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Prep for release Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]>

* Merge Preflight and PlanB removal feature branch (#1702) * VIDEO-7728 | Better Preflight Errors (#1689) * Adding better errors on preflight * lint * Update docs * Changelog * Update docs * Convert error to string * Adding timestamp to progress events * Properly raising signaling errors * lint * Update tests * Mak's feedback * Update test * Feature/remove plan b (#1697) * VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Fix unit test from merge * 2.20.0-rc2 * 2.20.0-dev * Update doc * Update changelog Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Removing framework tests (#1700) * Convert createLocalTracks to TS (#1694) * VIDEO-7714 - Convert createLocalTracks to TypeScript Co-authored-by: joma <[email protected]> Co-authored-by: charliesantos <[email protected]> * Update @twilio/webrtc to 4.6.0-rc1 (#1705) * Update @twilio-webrtc to RC Co-authored-by: joma <[email protected]> * 2.21.0-rc1 * 2.21.0-dev * merge from master * VIDEO-8791 - Adding extra information into CHANGELOG (#1716) * Adding extra information into CHANGELOG * 2.21.0-rc2 * 2.21.0-dev * VIDEO-8647 - Fixing Chrome Docker Image (#1718) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8954: Adding in extra links and details to the CHANGELOG entry (#1722) * VIDEO-8954 - Adding in extra links and details to the CHANGELOG entry * VIDEO-8647 - Fixing Chrome Docker Image (#1718) (#1721) (#1728) * VIDEO-8647 Fixing docker images build for Chrome * prep 2.21.0 release Co-authored-by: Charlemagne Santos <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> Co-authored-by: Makarand Patwardhan <[email protected]>

* Merge Preflight and PlanB removal feature branch (#1702) * VIDEO-7728 | Better Preflight Errors (#1689) * Adding better errors on preflight * lint * Update docs * Changelog * Update docs * Convert error to string * Adding timestamp to progress events * Properly raising signaling errors * lint * Update tests * Mak's feedback * Update test * Feature/remove plan b (#1697) * VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Fix unit test from merge * 2.20.0-rc2 * 2.20.0-dev * Update doc * Update changelog Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Removing framework tests (#1700) * Convert createLocalTracks to TS (#1694) * VIDEO-7714 - Convert createLocalTracks to TypeScript Co-authored-by: joma <[email protected]> Co-authored-by: charliesantos <[email protected]> * Update @twilio/webrtc to 4.6.0-rc1 (#1705) * Update @twilio-webrtc to RC Co-authored-by: joma <[email protected]> * 2.21.0-rc1 * 2.21.0-dev * merge from master * VIDEO-8791 - Adding extra information into CHANGELOG (#1716) * Adding extra information into CHANGELOG * 2.21.0-rc2 * 2.21.0-dev * VIDEO-8647 - Fixing Chrome Docker Image (#1718) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8954: Adding in extra links and details to the CHANGELOG entry (#1722) * VIDEO-8954 - Adding in extra links and details to the CHANGELOG entry * VIDEO-8647 - Fixing Chrome Docker Image (#1718) (#1721) (#1728) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8939 - Migrating twilio/webrtc (#1731) * VIDEO-8939 - Folding twilio/webrtc into SDK, installing util and events packages. * Prep for 2.21.1 RC (#1739) * Adding CHANGELOG entry for 2.21.1 RC * 2.21.1-rc1 * 2.21.1-dev * Edit changelog and readme for 2.21.1 release Co-authored-by: Charlemagne Santos <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> Co-authored-by: Makarand Patwardhan <[email protected]>

* Merge Preflight and PlanB removal feature branch (#1702) * VIDEO-7728 | Better Preflight Errors (#1689) * Adding better errors on preflight * lint * Update docs * Changelog * Update docs * Convert error to string * Adding timestamp to progress events * Properly raising signaling errors * lint * Update tests * Mak's feedback * Update test * Feature/remove plan b (#1697) * VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Fix unit test from merge * 2.20.0-rc2 * 2.20.0-dev * Update doc * Update changelog Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Removing framework tests (#1700) * Convert createLocalTracks to TS (#1694) * VIDEO-7714 - Convert createLocalTracks to TypeScript Co-authored-by: joma <[email protected]> Co-authored-by: charliesantos <[email protected]> * Update @twilio/webrtc to 4.6.0-rc1 (#1705) * Update @twilio-webrtc to RC Co-authored-by: joma <[email protected]> * 2.21.0-rc1 * 2.21.0-dev * merge from master * VIDEO-8791 - Adding extra information into CHANGELOG (#1716) * Adding extra information into CHANGELOG * 2.21.0-rc2 * 2.21.0-dev * VIDEO-8647 - Fixing Chrome Docker Image (#1718) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8954: Adding in extra links and details to the CHANGELOG entry (#1722) * VIDEO-8954 - Adding in extra links and details to the CHANGELOG entry * VIDEO-8647 - Fixing Chrome Docker Image (#1718) (#1721) (#1728) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8939 - Migrating twilio/webrtc (#1731) * VIDEO-8939 - Folding twilio/webrtc into SDK, installing util and events packages. * Prep for 2.21.1 RC (#1739) * Adding CHANGELOG entry for 2.21.1 RC * 2.21.1-rc1 * 2.21.1-dev * Marking unstable integration tests (#1740) * Marking unstable integration tests * merge from master (#1745) * VIDEO-9511 - do not configure encodings for stopped tracks (#1768) * do not update encodings for stopped tracks * Emit dimensionsChanged event on videoTrack start * Add test for videoTrack _start method * Add changelog entry for VIDEO-3576 * VIDEO-9282 - Migrate SDK from using node.js util. (#1752) * VIDEO-9282 - Removing all references to node dependencies. Co-authored-by: Makarand Patwardhan <[email protected]> * 2.21.2-rc1 * 2.21.2-dev * VIDEO-8282 - Adding iPad Detection (#1779) * VIDEO-8282 - Adding iPad and iPhone detection logic * 2.21.2-rc2 * 2.21.2-dev * Prep for 2.21.2 release, updating changelog Co-authored-by: Charlemagne Santos <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> Co-authored-by: Makarand Patwardhan <[email protected]> Co-authored-by: Tim Mendoza <[email protected]> Co-authored-by: timmydoza <[email protected]>

* Merge Preflight and PlanB removal feature branch (#1702) * VIDEO-7728 | Better Preflight Errors (#1689) * Adding better errors on preflight * lint * Update docs * Changelog * Update docs * Convert error to string * Adding timestamp to progress events * Properly raising signaling errors * lint * Update tests * Mak's feedback * Update test * Feature/remove plan b (#1697) * VIDEO-6587 | Remove Plan B in SDK (#1656) * Initial implementation. * Fixing integration tests * Updating unit tests * Adding back unit test job * Removing unneeded case * Fix build * Adding rename suggestion Co-authored-by: Manjesh Malavalli <[email protected]> * Adding changelog * Update CHANGELOG.md Co-authored-by: Manjesh Malavalli <[email protected]> * Adding ticket number Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> * Move changelog to 2.20.0 section * 2.20.0-rc1 * 2.20.0-dev Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Fix unit test from merge * 2.20.0-rc2 * 2.20.0-dev * Update doc * Update changelog Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> * Removing framework tests (#1700) * Convert createLocalTracks to TS (#1694) * VIDEO-7714 - Convert createLocalTracks to TypeScript Co-authored-by: joma <[email protected]> Co-authored-by: charliesantos <[email protected]> * Update @twilio/webrtc to 4.6.0-rc1 (#1705) * Update @twilio-webrtc to RC Co-authored-by: joma <[email protected]> * 2.21.0-rc1 * 2.21.0-dev * merge from master * VIDEO-8791 - Adding extra information into CHANGELOG (#1716) * Adding extra information into CHANGELOG * 2.21.0-rc2 * 2.21.0-dev * VIDEO-8647 - Fixing Chrome Docker Image (#1718) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8954: Adding in extra links and details to the CHANGELOG entry (#1722) * VIDEO-8954 - Adding in extra links and details to the CHANGELOG entry * VIDEO-8647 - Fixing Chrome Docker Image (#1718) (#1721) (#1728) * VIDEO-8647 Fixing docker images build for Chrome * VIDEO-8939 - Migrating twilio/webrtc (#1731) * VIDEO-8939 - Folding twilio/webrtc into SDK, installing util and events packages. * Prep for 2.21.1 RC (#1739) * Adding CHANGELOG entry for 2.21.1 RC * 2.21.1-rc1 * 2.21.1-dev * Marking unstable integration tests (#1740) * Marking unstable integration tests * merge from master (#1745) * VIDEO-9511 - do not configure encodings for stopped tracks (#1768) * do not update encodings for stopped tracks * Emit dimensionsChanged event on videoTrack start * Add test for videoTrack _start method * Add changelog entry for VIDEO-3576 * VIDEO-9282 - Migrate SDK from using node.js util. (#1752) * VIDEO-9282 - Removing all references to node dependencies. Co-authored-by: Makarand Patwardhan <[email protected]> * 2.21.2-rc1 * 2.21.2-dev * VIDEO-8282 - Adding iPad Detection (#1779) * VIDEO-8282 - Adding iPad and iPhone detection logic * 2.21.2-rc2 * 2.21.2-dev * Added details in changelog entry and updated insights payload constants (#1789) * 2.21.2-rc3 * 2.21.2-dev * Merge from master, resolving conflicts, adding new changelog entry (#1796) * VIDEO-10199 Update tooling back to working versions (#1798) * Adding platformName into insights payload (#1799) * Changelog for RC * 2.21.3-rc1 * 2.21.3-dev * Update changelog and readme Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]> Co-authored-by: Joyce Ma <[email protected]> Co-authored-by: joma <[email protected]> Co-authored-by: Makarand Patwardhan <[email protected]> Co-authored-by: Tim Mendoza <[email protected]> Co-authored-by: timmydoza <[email protected]>

manjeshbhargav and others added 7 commits November 16, 2021 10:19

Initial implementation.

02a2c34

Merge branch 'develop' into VIDEO-6587/remove-plan-b-in-sdk

ff8c22d

Fixing integration tests

f673f0e

Updating unit tests

5be6b05

Adding back unit test job

e6827ae

Removing unneeded case

be3f918

Fix build

3747219

charliesantos requested review from manjeshbhargav and makarandp0 November 30, 2021 18:34

manjeshbhargav reviewed Nov 30, 2021

View reviewed changes

charliesantos and others added 3 commits November 30, 2021 16:20

Adding rename suggestion

f071be0

Co-authored-by: Manjesh Malavalli <[email protected]>

Merge branch 'feature/remove_plan_b' into VIDEO-6587/remove-plan-b-in…

a06d4da

…-sdk

Adding changelog

9553e41

charliesantos requested a review from manjeshbhargav December 1, 2021 18:26

manjeshbhargav approved these changes Dec 1, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

charliesantos and others added 2 commits December 1, 2021 10:39

Update CHANGELOG.md

9f7544c

Co-authored-by: Manjesh Malavalli <[email protected]>

Adding ticket number

e7e49ee

charliesantos merged commit f15055a into feature/remove_plan_b Dec 1, 2021

manjeshbhargav deleted the VIDEO-6587/remove-plan-b-in-sdk branch February 23, 2022 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VIDEO-6587 | Remove Plan B in SDK #1656

VIDEO-6587 | Remove Plan B in SDK #1656

charliesantos commented Nov 30, 2021 •

edited

Loading

manjeshbhargav left a comment

manjeshbhargav Nov 30, 2021

charliesantos Dec 1, 2021

VIDEO-6587 | Remove Plan B in SDK #1656

VIDEO-6587 | Remove Plan B in SDK #1656

Conversation

charliesantos commented Nov 30, 2021 • edited Loading

manjeshbhargav left a comment

Choose a reason for hiding this comment

manjeshbhargav Nov 30, 2021

Choose a reason for hiding this comment

charliesantos Dec 1, 2021

Choose a reason for hiding this comment

charliesantos commented Nov 30, 2021 •

edited

Loading