Skip to content

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Jun 28, 2022

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

This PR removes constraints when requesting a screen share track. Removing the frame rate and resolution constraints should allow for higher quality screen share tracks to be published.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza merged commit e66fb0e into master Jun 29, 2022
@timmydoza timmydoza deleted the update-screen-share-settings branch June 29, 2022 05:06
@trickpattyFH20
Copy link

Was there another reason to remove these constraints? Leaving them in also causes a bug on macOS 13 Safari 16 that prevents getDisplayMedia from working. After removing the constraints it works fine @timmydoza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants