Skip to content

VIDEO-6368 | wait to load image before removing processor #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabriel-jt merged 2 commits into from
Aug 3, 2021
Merged

VIDEO-6368 | wait to load image before removing processor #570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a08b8
wait to load image before removing processor
Aug 2, 2021
ba1f715
refactored implementation
Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions src/components/VideoProvider/useBackgroundSettings/useBackgroundSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { LocalVideoTrack, Room } from 'twilio-video';
import { useState, useEffect } from 'react';
import { useState, useEffect, useCallback } from 'react';
import { SELECTED_BACKGROUND_SETTINGS_KEY } from '../../../constants';
import {
GaussianBlurBackgroundProcessor,
Expand Down Expand Up @@ -134,6 +134,24 @@ export default function useBackgroundSettings(videoTrack: LocalVideoTrack | unde
const localStorageSettings = window.localStorage.getItem(SELECTED_BACKGROUND_SETTINGS_KEY);
return localStorageSettings ? JSON.parse(localStorageSettings) : { type: 'none', index: 0 };
});

const removeProcessor = useCallback(() => {
if (videoTrack && videoTrack.processor) {
videoTrack.removeProcessor(videoTrack.processor);
}
}, [videoTrack]);

const addProcessor = useCallback(
(processor: GaussianBlurBackgroundProcessor | VirtualBackgroundProcessor) => {
if (!videoTrack || videoTrack.processor === processor) {
return;
}
removeProcessor();
videoTrack.addProcessor(processor);
},
[videoTrack, removeProcessor]
);

useEffect(() => {
if (!isSupported) {
return;
Expand All @@ -155,21 +173,22 @@ export default function useBackgroundSettings(videoTrack: LocalVideoTrack | unde
});
await virtualBackgroundProcessor.loadModel();
}
if (videoTrack && room?.localParticipant) {
if (videoTrack.processor) {
videoTrack.removeProcessor(videoTrack.processor);
}
if (backgroundSettings.type === 'blur') {
videoTrack.addProcessor(blurProcessor);
} else if (backgroundSettings.type === 'image' && typeof backgroundSettings.index === 'number') {
virtualBackgroundProcessor.backgroundImage = await getImage(backgroundSettings.index);
videoTrack.addProcessor(virtualBackgroundProcessor);
}
if (!room?.localParticipant) {
return;
}

if (backgroundSettings.type === 'blur') {
addProcessor(blurProcessor);
} else if (backgroundSettings.type === 'image' && typeof backgroundSettings.index === 'number') {
virtualBackgroundProcessor.backgroundImage = await getImage(backgroundSettings.index);
addProcessor(virtualBackgroundProcessor);
} else {
removeProcessor();
}
};
handleProcessorChange();
window.localStorage.setItem(SELECTED_BACKGROUND_SETTINGS_KEY, JSON.stringify(backgroundSettings));
}, [backgroundSettings, videoTrack, room]);
}, [backgroundSettings, videoTrack, room, addProcessor, removeProcessor]);

return [backgroundSettings, setBackgroundSettings] as const;
}