Fix firefox styling of textarea element #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olipyskoty
previously approved these changes
May 10, 2021
Contributor
olipyskoty
left a comment
olipyskoty
left a comment
There was a problem hiding this comment.
This looks good to me. Excited that we figured this one out!
| Here we add the "isTextareaFocused" class when the user is focused on the TextareaAutosize component. | ||
| This helps to ensure a consistent appearance across all browsers. Adding padding to the TextareaAutosize | ||
| component does not work well in Firefox. See: https://github.com/twilio/twilio-video-app-react/issues/498 | ||
| */} |
Contributor
There was a problem hiding this comment.
This is a very helpful comment!
Contributor
Author
|
It looks like this PR may have broken a Cypress test. I'll look into it. |
olipyskoty
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR fixes the styling of the chat input in firefox. The input now has a consistent appearance across all browsers. In Chrome and Safari, the appearance has not changed from how it looked previously.
Firefox:
To see what it looked like previously, see this issue: #498
Burndown
Before review
npm testBefore merge