Video 4893 show network for main participant#499
Merged
Conversation
Contributor
Author
|
@timmydoza I didn't think any unit tests needed to be updated for the |
timmydoza
suggested changes
Apr 22, 2021
Contributor
timmydoza
left a comment
timmydoza
left a comment
There was a problem hiding this comment.
Looks good! I think that's it. Just one tiny change request.
| '& svg': { | ||
| marginLeft: '0.3em', | ||
| }, | ||
| marginRight: '0.4em', |
Contributor
There was a problem hiding this comment.
I think the network container increased the height of the identity div just a little bit, which is totally fine. But it looks like things aren't centered vertically now. Let's add align-items: 'center', to the identity class.
Before:
After:
timmydoza
approved these changes
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR adds the network quality indicator to the main participant. This is the same network quality indicator that is used by the
<ParticipantInfo />component. We decided to move the styling to the<NetworkQualityLevel />in order to remove the empty boxes from the participant thumbnails in P2P rooms.GitHub issue: #490
Screenshots:
Main participant === localParticipant:
Main participant !== localParticipant:
Burndown
Before review
npm testBefore merge