Video 4673 remove preflight test

[olipyskoty]

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

• I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

• VIDEO-4673

Description

This PR addresses the question from GitHub issue #463.

We removed the <PreflightTest /> component from the React app. At one point, this app did run the preflight test that was found in the 2.8.0-beta version of the twilio-video SDK, however it was just a beta feature and hasn't been implemented in the current version of the SDK. We do plan on developing a new preflight test in the future.

Note: because of this, the SubContent found in the <PreJoinScreens /> was no longer necessary, so we moved the <MediaErrorSnackbar /> component to the render method in the <IntroContainer />. I've included a screenshot of what this will look like if an error is present:

Burndown

Before review

• Updated CHANGELOG.md if necessary
• Added Updated unit tests if necessary
• Updated affected documentation
• Verified locally with npm test
• Manually sanity tested running locally
• Included screenshot as PR comment (if needed)
• Ready for review

Before merge

• Got one or more +1s
• Re-tested if necessary

[timmydoza]

Here, I think it might be a little simpler if we just had the <MediaErrorSnackbar /> as a child of the IntroContainer, instead of a prop:

  return (
    <IntroContainer>
      <MediaErrorSnackbar error={mediaError} />

      {step === Steps.roomNameStep && (
        <RoomNameScreen
          name={name}
          roomName={roomName}
          setName={setName}
          setRoomName={setRoomName}
          handleSubmit={handleSubmit}
        />
      )}

      {step === Steps.deviceSelectionStep && (
        <DeviceSelectionScreen name={name} roomName={roomName} setStep={setStep} />
      )}
    </IntroContainer>
  );