fix usage of REACT_APP_TOKEN_ENDPOINT#486
Closed
arturodr wants to merge 1 commit intotwilio:masterfrom
Closed
Conversation
if passcode authentication is being used the flag REACT_APP_TOKEN_ENDPOINT currently was being ignored.
Contributor
|
Hi @arturodr - thanks for the pull request! I think the PR looks good, but unfortunately I can't merge it because our CircleCI tests aren't allowed to run on third-party pull requests due to security concerns. I created a new PR (#529 ) that contains your commit, so when I merge it you'll still be listed as a contributor. I'll close this PR and merge #529 in instead. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
Description
if passcode authentication is being used the flag REACT_APP_TOKEN_ENDPOINT currently was being ignored.
Burndown
Before review
npm testBefore merge