Skip to content

fix usage of REACT_APP_TOKEN_ENDPOINT#486

Closed
arturodr wants to merge 1 commit intotwilio:masterfrom
arturodr:master
Closed

fix usage of REACT_APP_TOKEN_ENDPOINT#486
arturodr wants to merge 1 commit intotwilio:masterfrom
arturodr:master

Conversation

@arturodr
Copy link
Contributor

@arturodr arturodr commented Apr 7, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

if passcode authentication is being used the flag REACT_APP_TOKEN_ENDPOINT currently was being ignored.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

if passcode authentication is being used the flag REACT_APP_TOKEN_ENDPOINT currently was being ignored.
@timmydoza
Copy link
Contributor

Hi @arturodr - thanks for the pull request!

I think the PR looks good, but unfortunately I can't merge it because our CircleCI tests aren't allowed to run on third-party pull requests due to security concerns. I created a new PR (#529 ) that contains your commit, so when I merge it you'll still be listed as a contributor.

I'll close this PR and merge #529 in instead.

Thanks!

@timmydoza timmydoza closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants