Skip to content

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Mar 4, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This PR fixes an issue where the UnsupportedBrowserWarning is not displayed on devices where Video.isSupported is false and navigator.mediaDevices doesn't exist (like older iPhones).

The <UnsupportedBrowserWarning> component needs to wrap the <AppStateProvider> component. The <AppStateProvider> uses the useActiveSinkId hook, which uses the useDevices hook, which attempt to access properties of navigator.mediaDevices. This change prevents navigator.mediaDevices from being access when it doesn't exist.

This change prevents the error that is seen in issue #439.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from charliesantos March 4, 2021 16:46
@timmydoza timmydoza linked an issue Mar 4, 2021 that may be closed by this pull request
@timmydoza timmydoza merged commit ed63721 into master Mar 4, 2021
@timmydoza timmydoza deleted the fix-unsupported-browser-warning branch March 4, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnsupportedBrowserWarning does not display on some unsupported devices

3 participants