Ensure dimension changes invalidate view#376
Closed
tomhicks wants to merge 1 commit intotwilio:masterfrom
Closed
Conversation
The track.dimensions object remains the same throughout the lifespan of the track, but its values are updated. This means that the setter always receives the same object and therefore doesn't result in the state actually changing. By copying the dimension values into a new object, we ensure that consumers of this hook are always kept up to date with the new dimensions.
Contributor
|
Thanks @tomhicks! What a great catch! For security reasons, our CI pipeline won't run on pull requests from outside contributors. So I've pulled your changes down, added a test case, and pushed up a new branch that I created a PR for. This way our CI test will run, and you will still be listed as a contributor. PR here: #387 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The track.dimensions object remains the same throughout the lifespan of the track, but its values are updated. This means that the setter always receives the same object and therefore doesn't result in the state actually changing.
By copying the dimension values into a new object, we ensure that consumers of this hook are always kept up to date with the new dimensions.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
A description of what this PR does.
Burndown
Before review
npm testBefore merge