Skip to content

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Oct 22, 2020

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR updates the useSelectedParticipant hook so that it listens to the participantDisconnected event. Now, when a participant leaves the room, they will be unpinned.

Fixes #338

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza merged commit e36e9cb into master Oct 22, 2020
@timmydoza timmydoza deleted the pinned-participant-disconnect branch October 22, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disconnecting a pinned participant does not update main participant

3 participants