Skip to content

Update firebase #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmydoza merged 4 commits into from
Oct 21, 2020
Merged

Update firebase #335

timmydoza merged 4 commits into from
Oct 21, 2020

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Oct 21, 2020 •
edited
Loading

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

N/A

Description

This PR does two small things.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza linked an issue Oct 21, 2020 that may be closed by this pull request
Requirement should be node engine >=10.19.0 and not 10+, as the serverless-api dependency requires the later version of NodeJS #270
Closed
@timmydoza timmydoza merged commit e7daa15 into master Oct 21, 2020
@timmydoza timmydoza deleted the update-firebase branch October 21, 2020 15:41
@timmydoza timmydoza mentioned this pull request Oct 21, 2020
Closed
jon-price-snke added a commit to visiontree-software/vtoc-fasttrack-video that referenced this pull request Oct 21, 2020
@jon-price-snke
Merge remote-tracking branch 'upstream/master' into master
dbec0ef 
* upstream/master:
  Update firebase (twilio#335)
  Revert "Increase throttle interval in ToggleVideoButton component"
  Increase throttle interval in ToggleVideoButton component
  Ahoyapps 771 store user preferences (twilio#333)
  Fix cypress flakiness (twilio#332)
  Bump @hapi/hoek from 8.5.0 to 8.5.1 (twilio#300)
  Update readme section about pricing (twilio#318)
  Implement Go Room Type Support and a Design Refresh (twilio#316)
  Add room type section to readme [skip ci] (twilio#306)
  Update twilio-video to version 2.7.2 (twilio#304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliesantos charliesantos charliesantos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Requirement should be node engine >=10.19.0 and not 10+, as the serverless-api dependency requires the later version of NodeJS

3 participants

@timmydoza @charliesantos