Skip to content

Set max tracks based on browser #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmydoza merged 2 commits into from
Jun 15, 2020
Merged

Set max tracks based on browser #244

timmydoza merged 2 commits into from
Jun 15, 2020

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Jun 15, 2020 •
edited
Loading

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR changes the default setting for max tracks to 10 for desktop browsers and 5 for mobile browsers.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from charliesantos June 15, 2020 17:49
@timmydoza timmydoza merged commit 3b1adfb into master Jun 15, 2020
@timmydoza timmydoza deleted the AHOYAPPS-596-set-max-tracks branch June 15, 2020 17:49
jon-price-snke added a commit to visiontree-software/vtoc-fasttrack-video that referenced this pull request Jun 16, 2020
@jon-price-snke
Merge remote-tracking branch 'upstream/master'
0739469 
* upstream/master:
  Set max tracks based on browser (twilio#244)
uriasn pushed a commit to Mastermind-com/twilio-video-app-react that referenced this pull request Oct 6, 2020
Set max tracks based on browser (twilio#244)
7403f57 
* Set max tracks based on browser

* Update snapshot tests
@twilio-product-security twilio-product-security mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliesantos charliesantos Awaiting requested review from charliesantos

1 more reviewer

@aaalaniz aaalaniz aaalaniz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timmydoza @aaalaniz