Refactor Controls component #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrecaredo
approved these changes
Nov 11, 2019
timmydoza
pushed a commit
that referenced
this pull request
Mar 6, 2020
* Refactor Controls component * Update test language
timmydoza
pushed a commit
that referenced
this pull request
Sep 30, 2020
…ss-tests Feature/design refresh fix cypress tests
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Refactor Controls component * Update test language
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Refactor Controls component * Update test language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
<Controls />component.Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR moves each button from the Controls component into their own component. Each button now has their own component file and their own test file. This simplifies the code and the tests, but it also prevents unnecessary renders of the buttons in the browser.
Burndown
Before review
npm testBefore merge