Ui improvements #16
Merged
Ui improvements #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliesantos
approved these changes
Nov 8, 2019
rrecaredo
reviewed
Nov 8, 2019
| {/* audio is disabled for this participant component because this participant's audio | ||
| is already being rendered in the <ParticipantStrip /> component. */} | ||
| <Participant participant={mainParticipant} disableAudio enableScreenShare /> | ||
| <MainParticipant /> |
rrecaredo
approved these changes
Nov 8, 2019
timmydoza
pushed a commit
that referenced
this pull request
Mar 6, 2020
* Make ParticipantStrip scrollable * Display room name when connected to a room * create MainParticipant component * Create MainParticipantInfo component * Add MainParticipant to room * Lint
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Make ParticipantStrip scrollable * Display room name when connected to a room * create MainParticipant component * Create MainParticipantInfo component * Add MainParticipant to room * Lint
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Make ParticipantStrip scrollable * Display room name when connected to a room * create MainParticipant component * Create MainParticipantInfo component * Add MainParticipant to room * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some UI improvements.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
MainParticipantandMainParticipantInfocomponents. This is because the information displayed over the main participant's video may be quite different from what is displayed in the sidebar, so we need two separate components. For instance, the main video area does not need to display the network quality (it's already in the sidebar), or icons for muted audio and video (already displayed in theControlscomponent for the local participant). Also, the main video area may display additional information, like the identity of the domainant speaker (if the video area is displaying a screen share from a different participant).Burndown
Before review
npm testBefore merge