Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github contributing and issue/PR template files #7

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

SergioFierro
Copy link
Collaborator

  • Add CONTRIBUTING.md
  • Add CODEOWNERS
  • Add PULL_REQUEST_TEMPLATE.md
  • Add issue templates

Copy link
Collaborator

@AlejandroOrozco AlejandroOrozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SergioFierro SergioFierro changed the title Add contributing file Add github contributing and issue/PR template files Feb 27, 2024
#These people are listed as being the code owners for this project. As such, they will be automatically added as a reviewer when a PR is created.
#For more details on how this is configured, see https://help.github.com/articles/about-code-owners/

* @SergioFierro @AlejandroOrozco @ferazoguerrero @dsantele

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use a group rather than the individual people here. I suggest also adding @jconama as well to said group fwiw.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, @twilio/accsec-apps-sdks

@SergioFierro SergioFierro requested review from a team and removed request for a team February 27, 2024 18:51
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Base automatically changed from sfierro/ACCSEC-33461-Add-License to dev February 28, 2024 14:17
@AuthyApps
Copy link

3 Warnings
⚠️ Please provide a summary in the Pull Request description
⚠️ The Pull Request summary does not contain the commit message convention
⚠️ The Pull Request title does not follow the convention [00000] PR Title text

Generated by 🚫 Danger

@AuthyApps
Copy link

1 Warning
⚠️

Size impact

ABI APK Size Impact
x86 2MB
x86_64 2MB
armeabi-v7a 2MB
arm64-v8a 2MB
universal 2MB

Generated by 🚫 Danger

@AuthyApps
Copy link

🧛 shared module Code Coverage: 96.16%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

CODEOWNERS
CONTRIBUTING.md
PULL_REQUEST_TEMPLATE.md
bug_report_template.md
feature_request_template.md

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@SergioFierro SergioFierro merged commit 4266c8a into dev Feb 28, 2024
8 checks passed
@SergioFierro SergioFierro deleted the sfierro/ACCSEC-33462-Add-contributing-file branch February 28, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants