SystemStackError when converting Message List to JSON

[Meekohi]

Expected this to work:

Version:

• ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin17]
• Rails 5.2.0
• gem 'twilio-ruby', '~> 5.11.1'

Code Snippet

> $twilio.api.account.messages.list.to_json
SystemStackError: stack level too deep
	from (irb):6

[Meekohi]

Pseudo-workaround

$twilio.api.account.messages.list.map{|mi| {
  to:mi.to, 
  from:mi.from, 
  body:mi.body, 
  created_at:mi.date_created, 
  sent_at:mi.date_sent, 
  direction:mi.direction, 
  error_code:mi.error_code, 
  error_message:mi.error_message
}}

[philnash]

So, just calling twilio.api.account.messages.list will paginate through all of your account's messages right back to the first one, populating an array with the results. If you have used your account for messages for any significant amount of time, then I would not recommend this at all.

I thought that the issue was going to be the sheer size of the array of messages, but it turns out that calling message.as_json on a single Twilio::REST::Api::V2010::AccountContext::MessageInstance will cause the same error. It seems that as_json from active support gets caught in a loop trying to turn the hash of values into JSON.

I'll investigate this further and see what I can find.

[chrisprijic]

Seems like a to_/as_json issue for any list coming through the SDK; I get the error with the following as well:

> $twilio.api.available_phone_numbers('US').local.list.to_json
SystemStackError: stack level too deep
	from (irb):6

For now, I'll be following @Meekohi 's solution for the available number listings in the meantime.

[childish-sambino]

Looks like there's a loop happening when recursing through instance_values since @version is an instance value which contains @account which contains @messages and forms a loop. I think the solution is to just include the instance properties as part of the JSON representation by adding this to all instance classes:

def as_json(*)
  @properties
end

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

[thinkingserious]

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

[michelson]

this is still an issue.