Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list of stringified json marshaling #82

Merged
merged 4 commits into from
Jul 6, 2021
Merged

fix: list of stringified json marshaling #82

merged 4 commits into from
Jul 6, 2021

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Jul 2, 2021 •
edited
Loading

@eshanholtz eshanholtz mentioned this pull request Jul 2, 2021
Merged
childish-sambino
childish-sambino reviewed Jul 3, 2021
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit test.

@JenniferMah
Copy link
Contributor

Have unit tests been added?

@eshanholtz eshanholtz merged commit fba5a1d into main Jul 6, 2021
@eshanholtz eshanholtz deleted the list-json branch July 6, 2021 23:57
RJPearson94 pushed a commit to RJPearson94/twilio-oai-generator that referenced this pull request Jul 9, 2021
@eshanholtz @RJPearson94
fix: list of stringified json marshaling (twilio#82)
e3f6a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino left review comments

@JenniferMah JenniferMah JenniferMah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eshanholtz @JenniferMah @childish-sambino