-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removed LTS version #978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! |
Please add the link of failed run/ axios issue, for future reference. |
shrutiburman
approved these changes
Nov 9, 2023
Done! |
sbansla
approved these changes
Nov 9, 2023
tiwarishubham635
added a commit
that referenced
this pull request
Nov 9, 2023
* chore: Removed LTS version (#978) * chore: removed LTS version * chore: removing lts from cloudscan * chore: completely removed LTS * chore: Update axios to 1.6 to pull in fix for CVE 2023 45857 (#971) * Update axios to 1.6.0 Fixes CVE-2023-45857 * Explicit type return on Promise TypeScript's automatic type resolution for the promise returned by the function in getExponentialBackoffResponseHandler determines that it returns a Promise<unknown>. This commit forces TypeScript to recognize that the resolved object is of type Promise<AxiosResponse>. --------- Co-authored-by: Shubham <[email protected]> * chore: twilio help changes (#958) Co-authored-by: Shubham <[email protected]> * chore: Removing Test Related To Deprecated Endpoint - OAuth (#963) * removing test in relation to deprecated endpoint * removingn more oauth refrences --------- Co-authored-by: sbansla <[email protected]> --------- Co-authored-by: Andrew Pietila <[email protected]> Co-authored-by: kridai <[email protected]> Co-authored-by: KobeBrooks <[email protected]> Co-authored-by: sbansla <[email protected]>
tiwarishubham635
added a commit
that referenced
this pull request
Nov 13, 2023
* chore: Removed LTS version (#978) * chore: removed LTS version * chore: removing lts from cloudscan * chore: completely removed LTS * chore: Update axios to 1.6 to pull in fix for CVE 2023 45857 (#971) * Update axios to 1.6.0 Fixes CVE-2023-45857 * Explicit type return on Promise TypeScript's automatic type resolution for the promise returned by the function in getExponentialBackoffResponseHandler determines that it returns a Promise<unknown>. This commit forces TypeScript to recognize that the resolved object is of type Promise<AxiosResponse>. --------- Co-authored-by: Shubham <[email protected]> * chore: twilio help changes (#958) Co-authored-by: Shubham <[email protected]> * chore: Removing Test Related To Deprecated Endpoint - OAuth (#963) * removing test in relation to deprecated endpoint * removingn more oauth refrences --------- Co-authored-by: sbansla <[email protected]> --------- Co-authored-by: Andrew Pietila <[email protected]> Co-authored-by: kridai <[email protected]> Co-authored-by: KobeBrooks <[email protected]> Co-authored-by: sbansla <[email protected]>
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Removed the LTS version from test and deploy pipeline as it was failing due to ongoing axios issue.
The Failed Run can be found here.
The Axios Issue can be found here
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.