Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Twilio Signature Validation #96

Merged
merged 7 commits into from
Jul 19, 2021
Merged

feat: Twilio Signature Validation #96

merged 7 commits into from
Jul 19, 2021

Conversation

pmcanseco
Copy link
Contributor

@pmcanseco pmcanseco commented Jul 15, 2021

Fixes #94

Implements Twilio Signature Validation, largely based on https://github.com/twilio/twilio-java . Their implementation can be found here and their test cases here. The documentation used for the algorithm for verifying Twilio Signatures was this one.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@pmcanseco pmcanseco marked this pull request as ready for review July 16, 2021 00:04
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution!

@eshanholtz eshanholtz merged commit 8d8fab8 into twilio:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Signature Validation utility
2 participants