Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RequestHandler for custom client support #80

Merged
merged 12 commits into from
May 20, 2021
Merged

Conversation

eshanholtz
Copy link
Contributor

This PR adds an additional layer to wrap the underlying BaseClient at the API level, allowing users to supply their own custom client functionality with minimal code. Region/Edge logic has been moved to this layer so that URL rebuilding functionality can be used even with a custom supplied client.

Related PRs:

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@eshanholtz eshanholtz merged commit 0c389ae into main May 20, 2021
@eshanholtz eshanholtz deleted the request-handler branch May 20, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants