Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add go linting as a pre commit hook #52

Merged
merged 1 commit into from
Mar 8, 2021
Merged

chore: add go linting as a pre commit hook #52

merged 1 commit into from
Mar 8, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke marked this pull request as draft March 5, 2021 19:20
@shwetha-manvinkurke shwetha-manvinkurke marked this pull request as ready for review March 5, 2021 19:28
eshanholtz
eshanholtz reviewed Mar 5, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke force-pushed the golint branch 2 times, most recently from 74561d0 to d5b8524 Compare March 5, 2021 19:44
thinkingserious
thinkingserious reviewed Mar 8, 2021
View reviewed changes
client/twilio_test.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
thinkingserious
thinkingserious approved these changes Mar 8, 2021
View reviewed changes
go.mod Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke merged commit 90b0d11 into main Mar 8, 2021
@shwetha-manvinkurke shwetha-manvinkurke deleted the golint branch March 8, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shwetha-manvinkurke @thinkingserious @eshanholtz