chore: pass query params in delete #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbansla
reviewed
Nov 20, 2024
| @@ -145,7 +145,7 @@ func (c *Client) SendRequest(method string, rawURL string, data url.Values, | |||
| // are added as information in the url itself. Also while Content-Type is json, we are sending | |||
| // json body. In that case, data variable contains all other parameters than body, which is the | |||
| //same case as GET method. In that case as well all parameters will be added to url | |||
| if method == http.MethodGet || contentType == jsonContentType { | |||
| if method == http.MethodGet || method == http.MethodDelete || contentType == jsonContentType { | |||
There was a problem hiding this comment.
Does this means that query parameter is only supported for Get and Delete methods.
There was a problem hiding this comment.
No, for put and post, it will be handled here
|
sbansla
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Currently, query params are passed only in the case of Get. Adding it to be passed for delete as well.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.