Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate setting of header params #249

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Jun 20, 2024

Fixes

Currently, contentType is being set in header at two places in case of form-url-encoded. One at this place, the other at this. Since we are passing it in headers, removing the explicit addition of contentType.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link

@tiwarishubham635 tiwarishubham635 requested a review from sbansla June 20, 2024 10:33
@tiwarishubham635 tiwarishubham635 merged commit f73a06f into main Jun 20, 2024
17 checks passed
@tiwarishubham635 tiwarishubham635 deleted the fix_content_type branch June 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants