Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cluster testing #100

Merged
merged 3 commits into from
Jul 19, 2021
Merged

feat: add cluster testing #100

merged 3 commits into from
Jul 19, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

Adds cluster testing where we test hitting endpoints with real creds

@shwetha-manvinkurke shwetha-manvinkurke marked this pull request as draft July 19, 2021 18:49
eshanholtz
eshanholtz reviewed Jul 19, 2021
View reviewed changes
rest/cluster_test.go Outdated Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke marked this pull request as ready for review July 19, 2021 19:25
JenniferMah
JenniferMah approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwetha-manvinkurke shwetha-manvinkurke merged commit f103905 into main Jul 19, 2021
@shwetha-manvinkurke shwetha-manvinkurke deleted the cluster-testing branch July 19, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino left review comments

@JenniferMah JenniferMah JenniferMah approved these changes

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shwetha-manvinkurke @eshanholtz @JenniferMah @childish-sambino